deniskuzZ commented on code in PR #3637:
URL: https://github.com/apache/hive/pull/3637#discussion_r1000329087
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAggregationDesc.java:
##########
@@ -126,6 +130,18 @@ public VectorAggregationDesc(String aggregationName,
GenericUDAFEvaluator evalua
this.vecAggrClass = vecAggrClass;
}
+ public VectorAggregationDesc(String aggregationName, GenericUDAFEvaluator
evaluator,
Review Comment:
Could we logically group parameters into their own higher-level object/use
Builder pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
