asolimando commented on code in PR #3317: URL: https://github.com/apache/hive/pull/3317#discussion_r1015227604
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/histogram/KllHistogramEstimator.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.common.histogram; + +import org.apache.datasketches.kll.KllFloatsSketch; +import org.apache.hadoop.hive.common.histogram.kll.KllUtils; +import org.apache.hadoop.hive.common.type.HiveDecimal; +import org.apache.hadoop.hive.ql.util.JavaDataModel; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; + +public class KllHistogramEstimator { Review Comment: Quoting from https://github.com/apache/hive/pull/3317#issuecomment-1148553006: > I am trying to figure out a better place to put an interface plus the concrete implementation(s) of the "complex" object incapsulating the different sketches: the only examples I could find are HyperLogLog (stored in the metastore-server module) and BloomFilter/BloomKFilter (stored in the storage-api module). As of now I have followed the HyperLogLog example but you seem to disagree, storage-api seems pretty arbitrary too, so I am not sure how to proceed here, do you have any suggestions? Do you have any suggestions for a better place to store those classes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
