scarlin-cloudera opened a new pull request, #3761:
URL: https://github.com/apache/hive/pull/3761
…alized views
When there is a materialized view in the materialized view registry, the
HiveMaterializedViewASTSubQueryRewriteShuttle runs and rewrites some RelNodes
and RexNodes.
On creation time, the HivePlannerContext is given the RexSubquery nodes
which are used to see if it is a correlated subquery with an agg. In the case
where the RexSubQuery was rewritten, the Context contains references to stale
nodes. It loses the correlated subquery information and creates an incorrect
query plan.
The boolean check for subqueries with agg is now done within the Calcite
nodes rather than when checking the ASTNodes. It was only used at rule time, so
it made more sense for the calculation of the boolean value to be done there,
and it's safer in the long run (as opposed to just update the global context
when a new RexSubQuery is created).
The HiveFilter and HiveProject will contain the structure holding the
calculated correlation information. The information is done with a lazy fetch
and only calculated when needed.
The HiveCorrelationInfo structure only contains information for the current
subquery level, similar to the old code. A correlated variable cannot go down
to a subquery within a subquery at this point.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Specified in description above
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Specified in description above
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Added q test which failed before change, succeeds after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
