zeroflag commented on code in PR #3769:
URL: https://github.com/apache/hive/pull/3769#discussion_r1024278069
##########
service/src/java/org/apache/hive/service/cli/operation/hplsql/HplSqlQueryExecutor.java:
##########
@@ -133,6 +138,11 @@ public <T> T get(int columnIndex, Class<T> type) {
if (type == Byte.class)
return type.cast(((Number) current[columnIndex]).byteValue());
}
+ // RowSet can never return BigDecimal or HiveDecimal instances, they'd
get converted to String
+ if (type == BigDecimal.class &&
Review Comment:
Does this check work for the HiveDecimal case too? If yes, then LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
