abstractdog commented on code in PR #3669:
URL: https://github.com/apache/hive/pull/3669#discussion_r1026089228
##########
llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java:
##########
@@ -390,6 +392,9 @@ public void initChannel(NioSocketChannel ch) throws
Exception {
if (sslFactory != null) {
pipeline.addLast("ssl", new
SslHandler(sslFactory.createSSLEngine()));
}
+ if (LOG.isDebugEnabled()) {
+ pipeline.addLast("loggingHandler", new
LoggingHandler(LogLevel.INFO));
Review Comment:
makes sense, but if we're about to do it on DEBUG level, wouldn't it rather
be:
```
new LoggingHandler(LogLevel.DEBUG)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
