zhangbutao commented on PR #3523: URL: https://github.com/apache/hive/pull/3523#issuecomment-1323938798
> I'm wondering how could weproceed with this, trying to understand TEZ-3302 in practice at the same time @zhangbutao , @rbalamohan : can you explain a scenario when this timeout is dangerous? if so, depending on the risk, we should be able to decide whether to approve this change (disabled) or abandon at all > > maybe it sounds weird, but I'm fine with an expert-level setting that can even lead to problems when used incorrectly (that's what we have everywhere in HiveConf :) ) > > I feel that if we can agree on this, that can let us proceed with [TEZ-4445](https://issues.apache.org/jira/browse/TEZ-4445) too @abstractdog Both this PR and https://issues.apache.org/jira/browse/TEZ-4445 were weird problems occasionally occuring in our busy cluster. I have no good luck to find these root causes, and just gave a workroud which adding timeout configuration. To be honest, i have no idea which specific danger could be introduced by this change so i disabled this by default. But as you said and i also definitily agreed, we can define it expert-level setting and let user choose to enable or disable it. I'd like to hear your opinion too. @rbalamohan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
