szlta commented on code in PR #3778: URL: https://github.com/apache/hive/pull/3778#discussion_r1030379645
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ########## @@ -2698,6 +2699,13 @@ public Table getTable(GetTableRequest getTableRequest) throws MetaException, TEx } } + private void extractTablePropertiesFromHook(Table t) throws MetaException { Review Comment: Why do we need this method? I guess the only reason is to have the hook presence check around postGetTable call. Maybe we could rename this that has nothing to do with properties? Implementors of postGetTable might have a different reason for implementing than property adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org