zabetak commented on code in PR #3839:
URL: https://github.com/apache/hive/pull/3839#discussion_r1042560998
##########
pom.xml:
##########
@@ -142,7 +142,7 @@
<hppc.version>0.7.2</hppc.version>
<!-- required for logging test to avoid including hbase which pulls
disruptor transitively -->
<disruptor.version>3.3.7</disruptor.version>
- <hikaricp.version>2.6.1</hikaricp.version>
Review Comment:
There is hikaricp.version also in `standalone-metastore/pom.xml`. The
upgrade should be done in both places.
##########
ql/pom.xml:
##########
@@ -1113,6 +1113,12 @@
<exclude>META-INF/licenses/slf4j*/**</exclude>
</excludes>
</filter>
+ <filter>
+ <artifact>com.zaxxer:HikariCP</artifact>
+ <excludes>
+ <exclude>META-INF/versions/11/module-info.class</exclude>
+ </excludes>
+ </filter>
Review Comment:
Why is this neccessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
