kasakrisz commented on code in PR #3843:
URL: https://github.com/apache/hive/pull/3843#discussion_r1043344684
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java:
##########
@@ -71,7 +73,10 @@ public class PlanModifierForASTConv {
public static RelNode convertOpTree(RelNode rel, List<FieldSchema>
resultSchema, boolean alignColumns)
throws CalciteSemanticException {
if (rel instanceof HiveValues) {
- return rel;
+ RelDataTypeFactory typeFactory = rel.getCluster().getTypeFactory();
+ List<String> fieldNames =
resultSchema.stream().map(FieldSchema::getName).collect(Collectors.toList());
+ fieldNames = SqlValidatorUtil.uniquify(fieldNames,
typeFactory.getTypeSystem().isSchemaCaseSensitive());
+ return ((HiveValues) rel).copy(fieldNames);
Review Comment:
I checked how `renameTopLevelSelectInResultSchema`
and when I went into details I found it calls
https://github.com/apache/calcite/blob/742d47795b878576f8cbdab5f62b26d95559792a/core/src/main/java/org/apache/calcite/rex/RexUtil.java#L1152
when creating the project.
I also wanted to call `renameTopLevelSelectInResultSchema` but it would
create a `Project` on top of `Values` which I want to avoid in order to
generate an AST of a pure empty plan so later we can exploit the optimization
which cancels query execution at the physical level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
