DanielZhu58 opened a new pull request, #3863:
URL: https://github.com/apache/hive/pull/3863

   ### What changes were proposed in this pull request?
   We only commit when all the changes in schema upgrade is successful.
   Otherwise, we do not commit.
   
   
   ### Why are the changes needed?
   Currently, as schematool applies schema changes during an upgrade, each 
change is autocommitted. So if it fails after applying a few changes from an 
upgrade file, those changes remain in the schema. So re-running the schematool 
fails at the first line because that change already exists.
   
   Instead, we should create a transactional boundary between each upgrade 
file, aka commit only after all the changes in an upgrade file are successful.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Maven build and unit test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to