ayushtkn commented on code in PR #3856:
URL: https://github.com/apache/hive/pull/3856#discussion_r1049592275


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1127,6 +1127,8 @@ public enum ConfVars {
       "command should handle partition retention. If enabled, and if a 
specific partition's age exceeded\n" +
       "retention period the partition will be dropped along with data"),
 
+    MATERIALIZED_VIEW_ENABLED("metastore.materialized.view.enabled", 
"metastore.materialized.view.enabled", true,

Review Comment:
   Notification LOG only logs metadata 'write' operations, it can't be use for 
Read auditing. 
   Second, the use case revolve around auditing the actual 'data' at the 'file 
level' with the user details and lot more present as part of HDFS(as for now) & 
some bits around Ranger Audit logs as well, MV will not bother the actual table 
data in the storage layer AFAIK and hence get skipped from being audited.
   
   On a lighter note, the defaults are in a way that existing functionality for 
anyone won't get impacted, but if someone has usecase he can use it :-) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to