ayushtkn commented on code in PR #3862:
URL: https://github.com/apache/hive/pull/3862#discussion_r1049891756


##########
iceberg/iceberg-shading/pom.xml:
##########
@@ -112,7 +112,11 @@
                       <include>com.google*:*</include>
                       <include>com.fasterxml*:*</include>
                       <include>com.github.ben-manes*:*</include>
+                      <include>org.apache.hive:patched-iceberg-core</include>

Review Comment:
   it was always there, I changed the iceberg-core to patched iceberg-core, the 
flow is like the patched modules -> then the iceberg-shading jar which contains 
all changes + some thirdparty libs -> then all this goes to 
hive-iceberg-handler with our hive copied modules
   And this is the only one complete jar which is packaged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to