deniskuzZ commented on code in PR #3887:
URL: https://github.com/apache/hive/pull/3887#discussion_r1054134017
##########
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:
##########
@@ -261,6 +274,8 @@ private boolean validateTxnList() throws
CommandProcessorException {
String userFromUGI = DriverUtils.getUserFromUGI(driverContext);
driverContext.getTxnManager().openTxn(context, userFromUGI,
driverContext.getTxnType());
+ // this is used by the test framework to more easily generate
conflicting transactions
+ if (testConflictCB != null) testConflictCB.run();
Review Comment:
Strong NO for this approach. Use mocking techniques and refactor the code if
needed. There shouldn't be any test hacks in the production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
