amanraj2520 commented on PR #3859: URL: https://github.com/apache/hive/pull/3859#issuecomment-1367087549
Hi @cnauroth Thanks a lot for your analysis. This helps me a lot. I will check this from my side in sometime and let you know. The thing that you were curious about, i think I can help sharing some light. Arrow started using netty in its 0.x releases. If we do not exclude netty from arrow while importing dependencies it will get the 4.1.22.Final netty. A point to be noted is that 4.1.22.Final and 4.1.28.Final(which I was planning to revert to) does not have this nonNull check in its stack trace. Therefore even if we upgrade netty to 4.1.69.Final and keep arrow as 0.x, it will pickup the 4.1.22.Final which will not have the nonNull check and it will pass. The problem came because we removed the arrow's netty in branch-3 while importing therefore forcing arrow to use 4.1.69.Final which has this null check and therefore this test fails. Hope this answers you question. We can discuss it further if you want. Having said this i also feel that fixing this test is the best approach and I will try fixing that in another pr. Will wait for someone to approve this first. Thanks a lot @cnauroth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
