deniskuzZ commented on code in PR #3849:
URL: https://github.com/apache/hive/pull/3849#discussion_r1060549210
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -521,4 +523,7 @@ default SnapshotContext
getCurrentSnapshotContext(org.apache.hadoop.hive.ql.meta
default void prepareAlterTableEnvironmentContext(AbstractAlterTableDesc
alterTableDesc,
EnvironmentContext environmentContext) {
}
+ default List<String> getIcebergPartitions(Configuration conf,
org.apache.hadoop.hive.ql.metadata.Table metaTable){
Review Comment:
should it be simply getPartitions and by default return
UnsupportedOperationException if someone decides to use it with a different
storage handler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]