veghlaci05 commented on code in PR #3916:
URL: https://github.com/apache/hive/pull/3916#discussion_r1063462016
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -271,7 +272,7 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
if (ci == null) {
return false;
}
- if ((runtimeVersion != null || ci.initiatorVersion != null) &&
!runtimeVersion.equals(ci.initiatorVersion)) {
+ if ((runtimeVersion != null && ci.initiatorVersion != null) &&
!runtimeVersion.equals(ci.initiatorVersion)) {
Review Comment:
with the old criteria if runtimeVersion is null and initiatorVersion is not
null, it will lead to an NPE. This change is unrelated to the PR, just wanted
to fix the issue above. However you are right this does not cover all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
