zabetak commented on code in PR #2:
URL: https://github.com/apache/hive-site/pull/2#discussion_r1064512219
##########
content/community/issueTracking.md:
##########
@@ -21,11 +22,14 @@ layout: default
specific language governing permissions and limitations
under the License. -->
-Hive tracks both bugs and enhancementrequests using [Apache
+# Issue Tracking
+---
+
+Hive tracks both bugs and enhancement requests using [Apache
JIRA]({{ site.jira }}/HIVE). We welcome input,
however, before filing a request, please make sure you do the
following:
- * Search the JIRA database.
- * Check the [user mailing list](/mailing_lists.html), both by searching the
archives and by asking questions.
+* Search the JIRA database.
+* Check the [user mailing list](/mailing_lists.html), both by searching the
archives and by asking questions.
Review Comment:
Dead link, please fix.
##########
config.toml:
##########
@@ -0,0 +1,52 @@
+baseURL = 'https://hive.apache.org/'
+languageCode = 'en-us'
+title = 'Hive Site'
+theme = 'hive'
+[params]
+ hiveLogo = "/images/hive.svg"
+ logo = "/images/asf_logo.png"
+ apacheURL = 'https://www.apache.org'
+ javaDocUrl =
'https://svn.apache.org/repos/infra/websites/production/hive/content/javadocs'
+
+[params.apache]
+ apacheUrl = "https://www.apache.org/";
+ license = "https://www.apache.org/licenses/";
+ howItWorks = "https://www.apache.org/foundation/how-it-works.html";
+ privacyPolicy =
"https://privacy.apache.org/policies/privacy-policy-public.html";
+ apacheEvents = "https://www.apache.org/events/current-event";
+ security = "https://www.apache.org/security/";
+ sponsors = "https://www.apache.org/foundation/thanks.html";
+ donate = "https://www.apache.org/foundation/sponsorship.html";
+ copyright = "The contents of this website are © 2022 Apache Software
Foundation under the terms of the Apache License v2. Apache Hive and its logo
are trademarks of the Apache Software Foundation."
+ thanks = "https://www.apache.org/foundation/thanks.html";
+
+[params.navbar]
+ release = "/general/downloads"
+ hcatalog = "/general/hcatalogdownloads/"
+ javaDocs = "/docs/javadocs/"
+ languageManual =
"https://cwiki.apache.org/confluence/display/Hive/LanguageManual";
+ wiki = "https://cwiki.apache.org/confluence/display/Hive/";
+ license2 = "https://www.apache.org/licenses/LICENSE-2.0.html";
+ privacyPolicy = "/general/privacypolicy/"
+ designDocs = "https://cwiki.apache.org/confluence/display/Hive/DesignDocs";
+ hiveJira = "https://issues.apache.org/jira/projects/HIVE/issues";
+ precommit =
"https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing";
+ faq = "https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ";
+ vcs = "/developement/versioncontrol/"
+ commiter =
"https://cwiki.apache.org/confluence/display/Hive/BecomingACommitter";
+ contribute =
"https://cwiki.apache.org/confluence/display/Hive/HowToContribute";
+ resourcesForDev =
"https://cwiki.apache.org/confluence/display/Hive/Home#Home-ResourcesforContributors";
+ mailinglist = "/community/mailinglist/"
+ issueTracking = "/community/issuetracking/"
+ people = "/community/people/"
+ bylaws = "https://cwiki.apache.org/confluence/display/Hive/Bylaws";
+ howToRelease =
"https://cwiki.apache.org/confluence/display/Hive/HowToRelease";
+
+[params.features]
+ acidTxn =
"https://cwiki.apache.org/confluence/display/hive/hive+transactions";
+ hs2 = "https://cwiki.apache.org/confluence/display/hive/hiveserver2";
Review Comment:
Broken link: replace with
`https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Overview`?
##########
config.toml:
##########
@@ -0,0 +1,52 @@
+baseURL = 'https://hive.apache.org/'
+languageCode = 'en-us'
+title = 'Hive Site'
+theme = 'hive'
+[params]
+ hiveLogo = "/images/hive.svg"
+ logo = "/images/asf_logo.png"
+ apacheURL = 'https://www.apache.org'
+ javaDocUrl =
'https://svn.apache.org/repos/infra/websites/production/hive/content/javadocs'
+
+[params.apache]
+ apacheUrl = "https://www.apache.org/";
+ license = "https://www.apache.org/licenses/";
+ howItWorks = "https://www.apache.org/foundation/how-it-works.html";
+ privacyPolicy =
"https://privacy.apache.org/policies/privacy-policy-public.html";
+ apacheEvents = "https://www.apache.org/events/current-event";
+ security = "https://www.apache.org/security/";
+ sponsors = "https://www.apache.org/foundation/thanks.html";
+ donate = "https://www.apache.org/foundation/sponsorship.html";
Review Comment:
`donate = https://www.apache.org/foundation/contributing.html`
##########
themes/hive/layouts/partials/menu.html:
##########
@@ -0,0 +1,114 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License. -->
+
+<menu style="background:black; margin:0rem">
+ <nav class="navbar navbar-expand-lg navbar-dark bg-black">
+ <div class="container-fluid">
+ <img src="{{.Site.BaseURL}}{{ .Site.Params.hiveLogo }}" width="60"
height="35" alt="Apache Software Foundation"></a>
+ <a class="header-text navbar-brand"
href="{{.Site.BaseURL}}">Apache Hive</a>
+ <button class="navbar-toggler" type="button"
data-bs-toggle="collapse" data-bs-target="#navbarSupportedContent"
aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle
navigation">
+ <span class="navbar-toggler-icon"></span>
+ </button>
+ <div class="collapse navbar-collapse" id="navbarSupportedContent">
+ <ul class="navbar-nav me-auto mb-2 mb-lg-0">
+
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="/Release"
id="navbarDropdown" role="button" data-bs-toggle="dropdown"
aria-expanded="false">
+ Release
+ </a>
+ <ul class="dropdown-menu"
aria-labelledby="navbarDropdown">
+ <li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.release }}">Release</a></li>
+ <li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.hcatalog }}">Hcatalog</a></li>
+
+ </ul>
+ </li>
+
+
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="/Document"
id="navbarDropdown" role="button" data-bs-toggle="dropdown"
aria-expanded="false">
+ Documentation
+ </a>
+ <ul class="dropdown-menu"
aria-labelledby="navbarDropdown">
+ <li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.javaDocs }}">Javadocs</a></li>
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.languageManual }}">Language Manual</a></li>
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.wiki }}">Wiki</a></li>
+ </ul>
+ </li>
+
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="/general"
id="navbarDropdown" role="button" data-bs-toggle="dropdown"
aria-expanded="false">
+ General
+ </a>
+ <ul class="dropdown-menu"
aria-labelledby="navbarDropdown">
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.license2 }}">License</a></li>
+ <li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.privacyPolicy }}">Privacy
Policy</a></li>
+ </ul>
+ </li>
+
+
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="#"
id="navbarDropdown" role="button" data-bs-toggle="dropdown"
aria-expanded="false">
+ Development
+ </a>
+ <ul class="dropdown-menu"
aria-labelledby="navbarDropdown">
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.designDocs }}">Design Docs</a></li>
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.hiveJira }}">Hive JIRA</a></li>
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.faq }}">Hive Developer FAQ</a></li>
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.precommit }}">Precommit Patch Testing</a></li>
+ <li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.vcs }}">Version Control</a></li>
+ </ul>
+ </li>
+
+
+ <li class="nav-item dropdown">
+ <a class="nav-link dropdown-toggle" href="#"
id="navbarDropdown" role="button" data-bs-toggle="dropdown"
aria-expanded="false">
+ Community
+ </a>
+ <ul class="dropdown-menu"
aria-labelledby="navbarDropdown">
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.commiter }}">Becoming A Committer</a></li>
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.contribute }}">How To Contribute</a></li>
+ <li><a class="dropdown-item" href="{{
.Site.Params.navbar.resourcesForDev }}">Resources for Contributors</a></li>
+ <li><a class="dropdown-item"
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.mailinglist }}">Mailing
List</a></li>
Review Comment:
Mailing List -> Mailing Lists
##########
themes/hive/layouts/partials/features.html:
##########
@@ -0,0 +1,170 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License. -->
+
+<features class="container text-style white-background">
+ <div>
+ <div class="row feature-intro">
+ <div class="row section-header-style">
+ <h2 class="section-header-text" style="text-align:
center;">What is Hive?</h2>
+ </div>
+ <p>
+ Apache Hive is a distributed, fault-tolerant data warehouse
system that enables analytics at a massive scale.
+ Hive Metastore(HMS) provides a central repository of metadata
that can easily be analyzed to make informed,
+ data driven decisions, and therefore it is a critical
component of many data lake architectures.
+
+ Hive is built on top of Apache Hadoop and supports storage on
S3, adls, gs etc though hdfs.
+ Hive allows users to read, write, and manage petabytes of data
using SQL.
+ </p>
+ </div>
+ <div class="row section-header-style">
+ <h2 class="section-header-text" style="text-align: center;">Key
Features</h2>
+ </div>
+ <div class="row divs">
+ {{- partial "hs2terminal.html" . -}}
+ <div class="col-md feature-border">
+ <h2 class="topic-text-style">Hive-Server 2 (HS2)</h2>
+ <p>
+ HS2 supports multi-client concurrency and authentication.
+ It is designed to provide better support for open API
clients like JDBC and ODBC.
+ </p>
+ <a href="{{ .Site.Params.features.hs2 }}" class="icon-block">
+ <button class="custom-button feature-button-style"
role="button">Learn More</button>
+ </a>
+ </div>
+ </div>
+
+ <div class="row divs">
+ <div class="col-md feature-border">
+ <h2 class="topic-text-style">Hive Metastore Server (HMS)</h2>
+ <p>
+ The Hive Metastore (HMS) is a central repository of
metadata for Hive tables and partitions in a relational database,
+ and provides clients (including Hive, Impala and Spark)
access to this information using the metastore service API.
+ It has become a building block for data lakes that utilize
the diverse world of open-source software, such as Apache Spark and Presto.
+ In fact, a whole ecosystem of tools, open-source and
otherwise, are built around the Hive Metastore, some of which this diagram
illustrates.
+ </p>
+ <a href="{{ .Site.Params.features.hms }}" class="icon-block">
+ <button class="custom-button feature-button-style"
role="button">Learn More</button>
+ </a>
+ </div>
+ <div class="col-md">
+ <a href="{{ .Site.Params.features.hms }}">
+ <img src="{{.Site.BaseURL}}/images/HMS.jpg" width="600"
height="400" alt="Apache Software Foundation"></a>
+ </a>
+ </div>
+ </div>
+
+ <div class="row divs">
+ <div class="col-md ">
+ <a href="{{ .Site.Params.features.acidTxn }}">
+ <img src="{{.Site.BaseURL}}/images/hiveAcid.svg"
width="300" height="300" alt="Apache Software Foundation"></a>
+ </a>
+ </div>
+ <div class="col-md feature-border">
+ <h2 class="topic-text-style">Hive ACID</h2>
+ <p>
+ Hive provides full acid support for ORC tables out and
insert only support to all other formats.
+ </p>
+ <a href="{{ .Site.Params.features.acidTxn }}"
class="icon-block">
+ <button class="custom-button feature-button-style"
role="button">Learn More</button>
+ </a>
+ </div>
+ </div>
+
+ <div class="row divs">
+ <div class="col-md feature-border">
+ <h2 class="topic-text-style">Hive Data Compaction</h2>
+ <p>
+ Query-based and MR-based data compactions are supported
out-of-the-box.
+ </p>
+ <a href="{{ .Site.Params.features.compactions }}"
class="icon-block">
+ <button class="custom-button feature-button-style"
role="button">Learn More</button>
+ </a>
+ </div>
+ <div class="col-md">
+ {{- partial "compaction.html" . -}}
+ </div>
+ </div>
Review Comment:
This is only relevant (and necessary) for ACID so maybe it is better to
merge it with the previous section instead of highlighting as a key feature.
##########
config.toml:
##########
@@ -0,0 +1,52 @@
+baseURL = 'https://hive.apache.org/'
+languageCode = 'en-us'
+title = 'Hive Site'
+theme = 'hive'
+[params]
+ hiveLogo = "/images/hive.svg"
+ logo = "/images/asf_logo.png"
+ apacheURL = 'https://www.apache.org'
+ javaDocUrl =
'https://svn.apache.org/repos/infra/websites/production/hive/content/javadocs'
+
+[params.apache]
+ apacheUrl = "https://www.apache.org/";
+ license = "https://www.apache.org/licenses/";
+ howItWorks = "https://www.apache.org/foundation/how-it-works.html";
+ privacyPolicy =
"https://privacy.apache.org/policies/privacy-policy-public.html";
+ apacheEvents = "https://www.apache.org/events/current-event";
+ security = "https://www.apache.org/security/";
+ sponsors = "https://www.apache.org/foundation/thanks.html";
Review Comment:
`sponsors = "https://www.apache.org/foundation/sponsorship.html"`
##########
content/community/mailingList.md:
##########
@@ -20,46 +22,49 @@ layout: default
specific language governing permissions and limitations
under the License. -->
+# Mailing List
Review Comment:
List -> Lists
##########
content/community/mailingList.md:
##########
@@ -1,7 +1,9 @@
---
-title: Mailing Lists
-layout: default
+title: "MailingList"
Review Comment:
MailingList -> MailingLists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
