simhadri-g commented on code in PR #2:
URL: https://github.com/apache/hive-site/pull/2#discussion_r1065434554


##########
themes/hive/layouts/partials/menu.html:
##########
@@ -0,0 +1,114 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License. -->
+
+<menu style="background:black; margin:0rem">
+    <nav class="navbar navbar-expand-lg navbar-dark bg-black">
+        <div class="container-fluid">
+            <img src="{{.Site.BaseURL}}{{ .Site.Params.hiveLogo }}" width="60" 
height="35"  alt="Apache Software Foundation"></a>
+            <a class="header-text navbar-brand" 
href="{{.Site.BaseURL}}">Apache Hive</a>
+            <button class="navbar-toggler" type="button" 
data-bs-toggle="collapse" data-bs-target="#navbarSupportedContent" 
aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle 
navigation">
+                <span class="navbar-toggler-icon"></span>
+            </button>
+            <div class="collapse navbar-collapse" id="navbarSupportedContent">
+                <ul class="navbar-nav me-auto mb-2 mb-lg-0">
+
+                    <li class="nav-item dropdown">
+                        <a class="nav-link dropdown-toggle" href="/Release" 
id="navbarDropdown" role="button" data-bs-toggle="dropdown" 
aria-expanded="false">
+                            Release
+                        </a>
+                        <ul class="dropdown-menu" 
aria-labelledby="navbarDropdown">
+                            <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.release }}">Release</a></li>
+                            <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.hcatalog }}">Hcatalog</a></li>
+
+                        </ul>
+                    </li>
+
+
+                    <li class="nav-item dropdown">
+                        <a class="nav-link dropdown-toggle" href="/Document" 
id="navbarDropdown" role="button" data-bs-toggle="dropdown" 
aria-expanded="false">
+                            Documentation
+                        </a>
+                        <ul class="dropdown-menu" 
aria-labelledby="navbarDropdown">
+                            <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.javaDocs }}">Javadocs</a></li>
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.languageManual }}">Language Manual</a></li>
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.wiki }}">Wiki</a></li>
+                        </ul>
+                    </li>
+
+                    <li class="nav-item dropdown">
+                        <a class="nav-link dropdown-toggle" href="/general" 
id="navbarDropdown" role="button" data-bs-toggle="dropdown" 
aria-expanded="false">
+                            General
+                        </a>
+                        <ul class="dropdown-menu" 
aria-labelledby="navbarDropdown">
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.license2 }}">License</a></li>
+                            <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.privacyPolicy }}">Privacy 
Policy</a></li>
+                        </ul>
+                    </li>
+
+
+                    <li class="nav-item dropdown">
+                        <a class="nav-link dropdown-toggle" href="#" 
id="navbarDropdown" role="button" data-bs-toggle="dropdown" 
aria-expanded="false">
+                            Development
+                        </a>
+                        <ul class="dropdown-menu" 
aria-labelledby="navbarDropdown">
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.designDocs }}">Design Docs</a></li>
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.hiveJira }}">Hive JIRA</a></li>
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.faq }}">Hive Developer FAQ</a></li>
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.precommit }}">Precommit Patch Testing</a></li>
+                            <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.vcs }}">Version Control</a></li>
+                        </ul>
+                    </li>
+
+
+                    <li class="nav-item dropdown">
+                        <a class="nav-link dropdown-toggle" href="#" 
id="navbarDropdown" role="button" data-bs-toggle="dropdown" 
aria-expanded="false">
+                            Community
+                        </a>
+                        <ul class="dropdown-menu" 
aria-labelledby="navbarDropdown">
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.commiter }}">Becoming A Committer</a></li>
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.contribute }}">How To Contribute</a></li>
+                            <li><a class="dropdown-item" href="{{ 
.Site.Params.navbar.resourcesForDev }}">Resources for Contributors</a></li>
+                            <li><a class="dropdown-item" 
href="{{.Site.BaseURL}}{{ .Site.Params.navbar.mailinglist }}">Mailing 
List</a></li>

Review Comment:
   Fixed



##########
config.toml:
##########
@@ -0,0 +1,52 @@
+baseURL = 'https://hive.apache.org/'
+languageCode = 'en-us'
+title = 'Hive Site'
+theme = 'hive'
+[params]
+  hiveLogo = "/images/hive.svg"
+  logo = "/images/asf_logo.png"
+  apacheURL = 'https://www.apache.org'
+  javaDocUrl = 
'https://svn.apache.org/repos/infra/websites/production/hive/content/javadocs'
+
+[params.apache]
+    apacheUrl = "https://www.apache.org/";
+    license = "https://www.apache.org/licenses/";
+    howItWorks = "https://www.apache.org/foundation/how-it-works.html";
+    privacyPolicy = 
"https://privacy.apache.org/policies/privacy-policy-public.html";
+    apacheEvents = "https://www.apache.org/events/current-event";
+    security = "https://www.apache.org/security/";
+    sponsors = "https://www.apache.org/foundation/thanks.html";
+    donate = "https://www.apache.org/foundation/sponsorship.html";
+    copyright = "The contents of this website are © 2022 Apache Software 
Foundation under the terms of the Apache License v2. Apache Hive and its logo 
are trademarks of the Apache Software Foundation."
+    thanks = "https://www.apache.org/foundation/thanks.html";
+
+[params.navbar]
+    release = "/general/downloads"
+    hcatalog = "/general/hcatalogdownloads/"
+    javaDocs = "/docs/javadocs/"
+    languageManual = 
"https://cwiki.apache.org/confluence/display/Hive/LanguageManual";
+    wiki = "https://cwiki.apache.org/confluence/display/Hive/";
+    license2 = "https://www.apache.org/licenses/LICENSE-2.0.html";
+    privacyPolicy = "/general/privacypolicy/"
+    designDocs = "https://cwiki.apache.org/confluence/display/Hive/DesignDocs";
+    hiveJira = "https://issues.apache.org/jira/projects/HIVE/issues";
+    precommit = 
"https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing";
+    faq = "https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ";
+    vcs = "/developement/versioncontrol/"
+    commiter = 
"https://cwiki.apache.org/confluence/display/Hive/BecomingACommitter";
+    contribute = 
"https://cwiki.apache.org/confluence/display/Hive/HowToContribute";
+    resourcesForDev = 
"https://cwiki.apache.org/confluence/display/Hive/Home#Home-ResourcesforContributors";
+    mailinglist = "/community/mailinglist/"
+    issueTracking = "/community/issuetracking/"
+    people = "/community/people/"
+    bylaws = "https://cwiki.apache.org/confluence/display/Hive/Bylaws";
+    howToRelease = 
"https://cwiki.apache.org/confluence/display/Hive/HowToRelease";
+
+[params.features]
+    acidTxn = 
"https://cwiki.apache.org/confluence/display/hive/hive+transactions";
+    hs2 = "https://cwiki.apache.org/confluence/display/hive/hiveserver2";

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to