SourabhBadhya commented on code in PR #3896:
URL: https://github.com/apache/hive/pull/3896#discussion_r1066553884
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFArrayBase.java:
##########
@@ -67,6 +76,8 @@ public ObjectInspector initialize(ObjectInspector[] arguments)
argumentOIs = arguments;
if (outputCategory == ObjectInspector.Category.LIST) {
return initListOI(arguments);
+ } else if (outputCategory == ObjectInspector.Category.PRIMITIVE &&
outputPrimitiveCategory == PrimitiveObjectInspector.PrimitiveCategory.STRING) {
+ return
PrimitiveObjectInspectorFactory.writableStringObjectInspector;
Review Comment:
I feel its better to push this down to GenericUDFArrayJoin by overriding
initialize in GenericUDFArrayJoin. This condition seems specific to Array join
and I dont see this condition used by other potential UDFs.
This will avoid the addition of another constructor as well to this generic
class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
