deniskuzZ commented on code in PR #3822:
URL: https://github.com/apache/hive/pull/3822#discussion_r1066729412
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -613,8 +613,9 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
return false;
}
- if (isNoAutoCompactSet(t.getParameters())) {
- LOG.info("Table " + tableName(t) + " marked " +
hive_metastoreConstants.TABLE_NO_AUTO_COMPACT +
+ Map<String, String> dbParams = computeIfAbsent(ci.dbname, () ->
resolveDatabase(ci)).getParameters();
Review Comment:
`isEligibleForCompaction` accepts the skipDBs SET, we should populate and
reuse it when checking the next candidates
````
if (isNoAutoCompactSet(dbParams, t.getParameters())) {
skipDbs.add(ci.dbname)
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
