zabetak commented on code in PR #3852:
URL: https://github.com/apache/hive/pull/3852#discussion_r1072443296
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3710,7 +3710,12 @@ public static enum ConfVars {
HIVE_EXPLAIN_USER("hive.explain.user", true,
"Whether to show explain result at user level.\n" +
"When enabled, will log EXPLAIN output for the query at user level.
Tez only."),
-
+ HIVE_EXPLAIN_VISIT_LIMIT("hive.explain.visit.limit", 256, new
RangeValidator(1, Integer.MAX_VALUE),
Review Comment:
The limit applies only when doing EXPLAIN thus the choice of this name.
Adding `node` in the property name is a good idea so I applied this change
(https://github.com/apache/hive/pull/3852/commits/5c9933e1a59fe6beeee83638cfa62f9ce887c711).
I opted to introduce a limit cause it is not possible to address the problem
at the EXPLAIN level without changing the output format.
There are many places where a graph is traversed in Hive and applying a
global limit everywhere would be difficult to enforce. Moreover, it would
possibly require changes in many places leading to a change with much bigger
impact.
If we want to go for a global visit limit then maybe it would be better to
do it as a separate JIRA/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
