zabetak commented on PR #3894: URL: https://github.com/apache/hive/pull/3894#issuecomment-1386890501
Thanks for the elaborate analysis and discussion @skysiders @cnauroth ! Looking into the changes it seems that this is kind of a breaking change since depending on the configuration permissions will be set differently. Moreover the proposed changes make the code more verbose and less straightforward. Furthermore, I am not sure we want to enforce a programming pattern where we do `fs.mkdirs` and then `fs.setPermission` since like that we essentially by-pass the umask that is the expected way of creating directories with the appropriate permissions (https://issues.apache.org/jira/browse/HDFS-1322?focusedCommentId=13072984&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13072984). For the reasons above, I would prefer if we didn't merge these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
