zratkai commented on code in PR #3882: URL: https://github.com/apache/hive/pull/3882#discussion_r1073453543
########## itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java: ########## @@ -236,7 +240,39 @@ public MiniLlapLocalCliConfig() { } } } + + public static class MiniLlapLocalCompactorCliConfig extends AbstractCliConfig { + + public MiniLlapLocalCompactorCliConfig() { + super(CoreCliDriver.class); + try { + setQueryDir("ql/src/test/queries/clientpositive"); + + includesFrom(testConfigProps, "compaction.query.files"); + setResultsDir("ql/src/test/results/clientpositive/llap"); + setLogDir("itests/qtest/target/qfile-results/clientpositive"); + + setInitScript("q_test_init.sql"); + setCleanupScript("q_test_cleanup.sql"); + + setHiveConfDir("data/conf/llap"); + setClusterType(MiniClusterType.LLAP_LOCAL); + setCustomConfigValueMap(createConfVarsStringMap()); + } catch (Exception e) { + throw new RuntimeException("can't construct cliconfig", e); + } + } + private static Map<HiveConf.ConfVars, String> createConfVarsStringMap() { + Map<HiveConf.ConfVars,String> customConfigValueMap = new HashMap<>(); + customConfigValueMap.put(HiveConf.ConfVars.HIVE_EXECUTION_ENGINE, "tez"); Review Comment: 1. It's true it should be TEZ already from config. 2. Ok, deleting this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org