zabetak commented on code in PR #3936:
URL: https://github.com/apache/hive/pull/3936#discussion_r1073576224
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rewrite/AlterMaterializedViewRewriteAnalyzer.java:
##########
@@ -68,10 +68,12 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
Table materializedViewTable = getTable(tableName, true);
// One last test: if we are enabling the rewrite, we need to check that
query
- // only uses transactional (MM and ACID) tables
+ // only uses transactional (MM and ACID and Iceberg) tables
if (rewriteEnable) {
for (SourceTable sourceTable :
materializedViewTable.getMVMetadata().getSourceTables()) {
- if (!AcidUtils.isTransactionalTable(sourceTable.getTable())) {
+ Table table = new Table(sourceTable.getTable());
+ if (!AcidUtils.isTransactionalTable(sourceTable.getTable()) &&
+ !(table.isNonNative() &&
table.getStorageHandler().areSnapshotsSupported())) {
throw new SemanticException("Automatic rewriting for materialized
view cannot be enabled if the " +
"materialized view uses non-transactional tables");
}
Review Comment:
Do we consider an Iceberg table as transactional? Should we change the
message to something more general. For example:
`Cannot enable materialized view rewriting cause view uses unsupported
tables`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
