akshat0395 commented on code in PR #3955:
URL: https://github.com/apache/hive/pull/3955#discussion_r1084047469


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3215,6 +3215,10 @@ public static enum ConfVars {
         "Time in seconds after which a compaction job will be declared failed 
and the\n" +
         "compaction re-queued."),
 
+    HIVE_COMPACTOR_WORKER_SLEEP_TIME("hive.compactor.worker.sleep.time", 
"10000ms",

Review Comment:
   The reason why these needs to be configurable is so that these values can be 
tweaked while testing as well, there are testcases like these 
https://github.com/apache/hive/blob/2031af314e70f3b8e07add13cb65416c29956181/ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestWorker.java#L1190
   Which simulates the timeout scenarios for worker and when worker goes in 
timeout we send the thread to sleep for long duration of time. To avoid sending 
threads to go to sleep for long duration while testing we set lower values for 
these in tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to