saihemanth-cloudera commented on code in PR #3966:
URL: https://github.com/apache/hive/pull/3966#discussion_r1084781514
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -5239,12 +5236,9 @@ public List<Partition> alterPartitions(String catName,
String dbName, String tbl
tblName = normalizeIdentifier(tblName);
List<MPartition> mPartitionList;
- try (Query query = pm.newQuery(MPartition.class,
- "table.tableName == t1 && table.database.name == t2 &&
t3.contains(partitionName) " +
- " && table.database.catalogName == t4")) {
- query.declareParameters("java.lang.String t1, java.lang.String t2,
java.util.Collection t3, "
- + "java.lang.String t4");
- mPartitionList = (List<MPartition>) query.executeWithArray(tblName,
dbName, partNames, catName);
+ Pair<Query, Map<String, String>> queryWithParams =
getPartQueryWithParams(catName, dbName, tblName, partNames);
Review Comment:
I see that now the sql query has become partitionName= p1 ||
partitionName=p2 instead of partitionName.contains(p1). I'm wondering how this
would impact 10k+ partitions or 1M partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
