zabetak commented on code in PR #3938:
URL: https://github.com/apache/hive/pull/3938#discussion_r1087810684
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java:
##########
@@ -203,11 +203,12 @@ public Result invokeInternal(final Object proxy, final
Method method, final Obje
}
}
- if (retryCount >= retryLimit) {
+ Throwable rootCause = ExceptionUtils.getRootCause(caughtException);
+ String errorMessage = ExceptionUtils.getMessage(caughtException) +
Review Comment:
Users are not necessarily developers; throwing exceptions back to them
should be the norm. Consider for instance some of the most popular DBMS
(Postgres, Oracle, MSSQL, etc); I don't think anyone is exposing exceptions to
the user.
This is a minor comment not really blocking but I wanted to mention that
propagating exceptions to the client is not the ideal solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
