abstractdog commented on PR #3779: URL: https://github.com/apache/hive/pull/3779#issuecomment-1407699051
I don't know the implementation details of the original SingleFileSystem, but the manner of addition looks convenient, so this patch also looks good to me we haven't added tests for specific underlying filesystems so far, if manual tests worked for ofs, this is good to go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
