veghlaci05 commented on code in PR #4024:
URL: https://github.com/apache/hive/pull/4024#discussion_r1100286436
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java:
##########
@@ -94,19 +94,15 @@ public YarnQueueHelper(HiveConf conf) {
}
public void checkQueueAccess(
- String queueName, String userName) throws IOException,
InterruptedException {
+ String queueName, String userName) throws IOException {
UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
try {
ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
checkQueueAccessInternal(queueName, userName);
return null;
});
- } finally {
- try {
- FileSystem.closeAllForUGI(ugi);
- } catch (IOException exception) {
- LOG.error("Could not clean up file-system handles for UGI: " + ugi,
exception);
- }
Review Comment:
@ayushtkn There is no need to call FileSystem.closeAllForUGI(ugi) here, the
close is handled elsewhere and worked fine earlier. When I added the
`ugi.doAs(...` call in https://github.com/apache/hive/pull/3402, I accidentally
added the finally block as well, which is not required here at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
