deniskuzZ commented on code in PR #4032:
URL: https://github.com/apache/hive/pull/4032#discussion_r1124208770
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java:
##########
@@ -97,16 +90,11 @@ public void init(AtomicBoolean stop) throws Exception {
}
@Override List<Partition> getPartitionsByNames(CompactionInfo ci) throws
MetaException {
- try {
- return getMSForConf(conf).getPartitionsByNames(getDefaultCatalog(conf),
ci.dbname, ci.tableName,
- Collections.singletonList(ci.partName));
- } catch (MetaException e) {
- LOG.error("Unable to get partitions by name for CompactionInfo=" + ci);
- throw e;
- } catch (NoSuchObjectException e) {
- LOG.error("Unable to get partitions by name for CompactionInfo=" + ci);
- throw new MetaException(e.toString());
- }
+ return CompactorUtil.getPartitionsByNames(conf, ci.dbname, ci.tableName,
ci.partName);
+ }
+
+ public boolean isCacheEnabled() {
Review Comment:
shouldn't it be abstract?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
