deniskuzZ commented on code in PR #4088:
URL: https://github.com/apache/hive/pull/4088#discussion_r1124436872
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -98,8 +98,12 @@ public void initialize(String inputName, Map<String, String>
properties) {
this.listAllTables =
Boolean.parseBoolean(properties.getOrDefault(LIST_ALL_TABLES,
LIST_ALL_TABLES_DEFAULT));
String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO = fileIOImpl == null ? new HadoopFileIO(conf) :
CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
-
+ if (fileIOImpl == null) {
+ this.fileIO = new HadoopFileIO(conf);
+ this.fileIO.initialize(properties);
Review Comment:
what does it do? looks like impl is missing
````
default void initialize(Map<String, String> properties)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
