kasakrisz commented on code in PR #4079:
URL: https://github.com/apache/hive/pull/4079#discussion_r1127942490
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -116,6 +116,13 @@ private static TableScan createTableScan(Table table,
Configuration conf) {
scan = scan.useSnapshot(snapshotId);
}
+ if (snapshotId == -1) {
Review Comment:
SNAPSHOT_ID_INTERVAL_FROM handling is moved to else block.
AS_OF_TIMESTAMP was independently set from SNAPSHOT_ID. Is it possible to
construct a query where both are present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
