vamshikolanu commented on code in PR #4110: URL: https://github.com/apache/hive/pull/4110#discussion_r1132947723
########## ql/src/test/queries/clientpositive/limit_max_int.q: ########## @@ -0,0 +1,6 @@ +--! qt:dataset:src +select key from src limit 214748364700; +select key from src where key = '238' limit 214748364700; +select * from src where key = '238' limit 214748364700; +select src.key, count(src.value) from src group by src.key limit 214748364700; +select * from ( select key from src limit 3) sq1 limit 214748364700; Review Comment: limit query fails for negative numbers at the parser level. Hence I haven't added it for a negative number. convertStringToBoundedInt() made it generic to handle both positive and negative cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
