kasakrisz commented on code in PR #4079:
URL: https://github.com/apache/hive/pull/4079#discussion_r1133640784


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewUtils.java:
##########
@@ -277,6 +276,20 @@ public void visit(RelNode node, int ordinal, RelNode 
parent) {
             materialization.getAst());
   }
 
+  private static HiveRelOptMaterialization 
augmentMaterializationWithTimeInformation(

Review Comment:
   This method is part of the
   ```
   public static HiveRelOptMaterialization 
augmentMaterializationWithTimeInformation(
         HiveRelOptMaterialization materialization, String validTxnsList,
         MaterializationSnapshot snapshot) throws LockException
   ```
   method.
   These utility methods construct a rule parameterize it with the saved 
Materialized view creation metadata and apply it to the MV query plan.
   I refactored these to extract common parts and make it more readable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to