saihemanth-cloudera commented on code in PR #4137:
URL: https://github.com/apache/hive/pull/4137#discussion_r1146377288
##########
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java:
##########
@@ -310,7 +310,7 @@ protected synchronized TTransport connect(HiveConf conf)
throws HiveSQLException
String host = conf.getVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST);
int port = conf.getIntVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_PORT);
- int maxThriftMessageSize = (int)
conf.getSizeVar(HiveConf.ConfVars.HIVE_THRIFT_CLIENT_MAX_MESSAGE_SIZE);
+ int maxThriftMessageSize = (int)
Math.min(conf.getSizeVar(HiveConf.ConfVars.HIVE_THRIFT_CLIENT_MAX_MESSAGE_SIZE),Integer.MAX_VALUE);
LOG.info("Connecting to " + host + ":" + port);
Review Comment:
I think it should be ok to change L#314 as follows:
LOG.info("Connecting to " + host + ":" + port+ " using a thrift max message
of size: "+ maxThriftMessageSize);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
