ayushtkn commented on code in PR #4158:
URL: https://github.com/apache/hive/pull/4158#discussion_r1149193455
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilterMerge.java:
##########
@@ -602,4 +602,11 @@ public void assignRowColumn(VectorizedRowBatch batch, int
batchIndex, int column
Aggregation bfAgg = (Aggregation) agg;
outputColVector.setVal(batchIndex, bfAgg.bfBytes, 0, bfAgg.bfBytes.length);
}
+
+ /**
+ * Let's clone the batch when we're working in parallel, see HIVE-26655.
+ */
+ public boolean batchNeedsClone() {
+ return numThreads > 0;
+ }
Review Comment:
just a quick pass, if thread count is 1, you still need a clone? for
parallel execution it should be more than 1 thread? or some catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
