[GitHub] [hive] SourabhBadhya commented on a diff in pull request #4091: HIVE-27020: Implement a separate handler to handle aborted transaction cleanup

[via GitHub]

SourabhBadhya commented on code in PR #4091:
URL: https://github.com/apache/hive/pull/4091#discussion_r1154417738


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java:
##########
@@ -84,6 +84,28 @@ public static ValidTxnList 
createValidTxnListForCleaner(GetOpenTxnsResponse txns
     // string as they'd have to know which object to instantiate
     return new ValidReadTxnList(abortedTxns, bitSet, highWaterMark, 
Long.MAX_VALUE);
   }
+
+  public static ValidTxnList 
createValidTxnListForTxnAbortedCleaner(GetOpenTxnsResponse txns, long 
minOpenTxn) {
+    long highWaterMark = minOpenTxn - 1;

Review Comment:
   Changed. Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org