abstractdog commented on code in PR #4121:
URL: https://github.com/apache/hive/pull/4121#discussion_r1158169932
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java:
##########
@@ -1234,7 +1234,7 @@ public void emptyFile() throws Exception {
assertEquals(false, reader.rows().hasNext());
assertEquals(CompressionKind.NONE, reader.getCompression());
assertEquals(0, reader.getNumberOfRows());
- assertEquals(0, reader.getCompressionSize());
+ assertEquals(262144, reader.getCompressionSize());
Review Comment:
this looks a bit weird...I mean any non-zero to non-zero change is okay as
file size changes, but 0 -> 262144 is strange, do we know the root cause? was
the assertion of =0 made intentionally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
