deniskuzZ commented on code in PR #4155:
URL: https://github.com/apache/hive/pull/4155#discussion_r1162652949
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergMigration.java:
##########
@@ -266,10 +292,14 @@ public void testMigrationFailsForManagedTable() {
"('storage_handler'='org.apache.iceberg.mr.hive.HiveIcebergStorageHandler')"));
}
- private void validateMigration(String tableName) throws TException,
InterruptedException {
+ private Table validateMigration(String tableName, String tblProperties)
Review Comment:
can we keep `validateMigration` with 1 argument, to avoid passing `null` in
multiple places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
