kasakrisz commented on code in PR #4237: URL: https://github.com/apache/hive/pull/4237#discussion_r1168331370
########## ql/src/test/queries/clientpositive/pointlookup6.q: ########## @@ -0,0 +1,17 @@ +create table r_table ( Review Comment: Changing `hive.optimize.point.lookup` to `false` changes the plan in the test output so I wouldn't add this explicitly. It would also turn off the whole point lookup optimization functionality and in general we don't want to turn off any functionality because it would lead to dead functionalities and make very hard to re-enable it after a while. I added ``` set hive.optimize.point.lookup.min=2 ``` It makes sense in this test case since we have only two constants in the `IN` expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
