henrib commented on code in PR #4194: URL: https://github.com/apache/hive/pull/4194#discussion_r1175396173
########## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/properties/HMSPropertyStoreRemoteTest.java: ########## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.metastore.properties; + +import org.apache.commons.io.IOUtils; +import org.apache.commons.jexl3.JxltEngine; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.metastore.HMSHandler; +import org.apache.hadoop.hive.metastore.HiveMetaStore; +import org.apache.hadoop.hive.metastore.HiveMetaStoreClient; +import org.apache.hadoop.hive.metastore.JdoPropertyStore; +import org.apache.hadoop.hive.metastore.MetaStoreTestUtils; +import org.apache.hadoop.hive.metastore.ObjectStore; +import org.apache.hadoop.hive.metastore.TestObjectStore; +import org.apache.hadoop.hive.metastore.Warehouse; +import org.apache.hadoop.hive.metastore.api.InvalidInputException; +import org.apache.hadoop.hive.metastore.api.InvalidObjectException; +import org.apache.hadoop.hive.metastore.api.InvalidOperationException; +import org.apache.hadoop.hive.metastore.api.MaintenanceOpStatus; +import org.apache.hadoop.hive.metastore.api.MaintenanceOpType; +import org.apache.hadoop.hive.metastore.api.MetaException; +import org.apache.hadoop.hive.metastore.client.builder.DatabaseBuilder; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; +import org.apache.hadoop.hive.metastore.security.HadoopThriftAuthBridge; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +import java.io.StringWriter; +import java.util.Map; +import java.util.TreeMap; + +import static org.apache.hadoop.hive.metastore.properties.HMSPropertyManager.JEXL; +import static org.apache.hadoop.hive.metastore.properties.HMSPropertyManager.MAINTENANCE_OPERATION; +import static org.apache.hadoop.hive.metastore.properties.HMSPropertyManager.MAINTENANCE_STATUS; +import static org.apache.hadoop.hive.metastore.properties.PropertyType.BOOLEAN; +import static org.apache.hadoop.hive.metastore.properties.PropertyType.DATETIME; +import static org.apache.hadoop.hive.metastore.properties.PropertyType.DOUBLE; +import static org.apache.hadoop.hive.metastore.properties.PropertyType.INTEGER; +import static org.apache.hadoop.hive.metastore.properties.PropertyType.JSON; +import static org.apache.hadoop.hive.metastore.properties.PropertyType.STRING; + +public class HMSPropertyStoreRemoteTest extends HMSPropertyStoreTest { + //private static final String NS = "hms"; + protected HiveMetaStoreClient client; + private boolean isServerStarted = false; + protected int port; + + boolean createStore(Configuration conf, Warehouse wh) { + try { + MetaStoreTestUtils.setConfForStandloneMode(conf); + objectStore = new ObjectStore(); + objectStore.setConf(conf); + //TestObjectStore.dropAllStoreObjects(objectStore); + HMSHandler.createDefaultCatalog(objectStore, wh); + // configure object store + objectStore.createDatabase(new DatabaseBuilder() + .setCatalogName("hive") + .setName(DB1) + .setDescription("description") + .setLocation("locationurl") + .build(conf)); + } catch(InvalidObjectException | MetaException | InvalidOperationException xmeta) { + throw new PropertyException("unable to initialize server", xmeta); + } + return true; + } + + @Before + public void setUp() throws Exception { + conf = MetastoreConf.newMetastoreConf(); + MetastoreConf.setBoolVar(conf, MetastoreConf.ConfVars.HIVE_IN_TEST, true); + // Events that get cleaned happen in batches of 1 to exercise batching code + MetastoreConf.setLongVar(conf, MetastoreConf.ConfVars.EVENT_CLEAN_MAX_EVENTS, 1L); + MetaStoreTestUtils.setConfForStandloneMode(conf); + if (isServerStarted) { + Assert.assertNotNull("Unable to connect to the MetaStore server", client); + return; + } + port = MetaStoreTestUtils.startMetaStoreWithRetry(HadoopThriftAuthBridge.getBridge(), conf); + System.out.println("Starting MetaStore Server on port " + port); + isServerStarted = true; + + Warehouse wh = new Warehouse(conf); + boolean inited = createStore(conf, wh); + LOG.info("MetaStore Thrift Server test initialization " + (inited? "successful":"failed")); + // This is default case with setugi off for both client and server + client = createClient(); + } + + + protected HiveMetaStoreClient createClient() throws Exception { + MetastoreConf.setVar(conf, MetastoreConf.ConfVars.THRIFT_URIS, "thrift://localhost:" + port); + MetastoreConf.setBoolVar(conf, MetastoreConf.ConfVars.EXECUTE_SET_UGI, false); + HiveMetaStoreClient client = new HiveMetaStoreClient(conf); + return client; + } + + @After + public void tearDown() throws Exception { + MetaStoreTestUtils.close(port); + super.tearDown(); + } + + @Test + public void testHMSProperties() throws Exception { Review Comment: Refactored the unit tests (and added a Servlet skeleton to test another transport). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
