dengzhhu653 commented on code in PR #4263: URL: https://github.com/apache/hive/pull/4263#discussion_r1176172165
########## jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/TeradataDatabaseAccessor.java: ########## @@ -0,0 +1,41 @@ +/* + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hive.storage.jdbc.dao; + +/** + * Teradata specific data accessor. This is needed because Teradata JDBC drivers do not support generic LIMIT and OFFSET + * escape functions + */ +public class TeradataDatabaseAccessor extends GenericJdbcDatabaseAccessor { + + @Override Review Comment: nit: this file seems unrelated to the problem, should we create another jira for the feature? I think it makes better for porting or tracking the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
