dengzhhu653 commented on code in PR #4258: URL: https://github.com/apache/hive/pull/4258#discussion_r1176320733
########## ql/src/test/queries/clientpositive/authorization_privilege_objects.q: ########## @@ -0,0 +1,20 @@ +--! qt:authorizer +set hive.security.authorization.manager=org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest; +set test.hive.authz.sstd.validator.outputPrivObjs=true; +set hive.test.authz.sstd.hs2.mode=true; +set user.name=testuser; + +CREATE DATABASE test_db; +CREATE TABLE test_privs(i int); +set user.name=testuser2; +CREATE TABLE test_privs2(s string, i int); +set user.name=testuser; +SHOW DATABASES; +SHOW TABLES; Review Comment: nit: I'm wondering these queries doesn't reach the `getTableMeta` method. ########## ql/src/test/queries/clientpositive/authorization_privilege_objects.q: ########## @@ -0,0 +1,20 @@ +--! qt:authorizer +set hive.security.authorization.manager=org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest; +set test.hive.authz.sstd.validator.outputPrivObjs=true; +set hive.test.authz.sstd.hs2.mode=true; +set user.name=testuser; + +CREATE DATABASE test_db; +CREATE TABLE test_privs(i int); +set user.name=testuser2; +CREATE TABLE test_privs2(s string, i int); +set user.name=testuser; +SHOW DATABASES; +SHOW TABLES; Review Comment: nit: I'm wondering these queries don't reach the `getTableMeta` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
