abstractdog commented on PR #4268: URL: https://github.com/apache/hive/pull/4268#issuecomment-1523079640
> LGTM. Since `AbstractExternalDB` is more or less a copy (unfortunately :( ) of `DatabaseRule` we may want to apply the same improvements there; it can be done as part of this PR or a separate one. makes sense, I'm porting changes to DatabaseRule, otherwise I'll forget forever -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
