pvary commented on PR #4252: URL: https://github.com/apache/hive/pull/4252#issuecomment-1523621934
> @InvisibleProgrammer Thanks for sharing your thought! The two commits `fede493d59f17ff2bfc0744b296d90bd36130386` and `333227fbd13821365cec1bdbfcb9314a239bea0f` are realy hard to deal. We shoud carefully handle these commits. I also hope the author of two commits can give us some info to evaluate if it is very necessary to port in current Hive `iceberg-handler` moduel @pvary . There is a new commit which could be helpful, because it removes the need to issue a HiveLock on alter table: - c3232b664745ebf761b6a74f4c5b55cc48bfd209: Hive: Use EnvironmentContext instead of Hive Locks to provide transactional commits after HIVE-26882 - This is based on 333227fbd13821365cec1bdbfcb9314a239bea0f and fede493d59f17ff2bfc0744b296d90bd36130386. Has to be a parallel change on Hive/Impala and every writers of the Iceberg table, but fixes stability and enhances commit performance - 333227fbd13821365cec1bdbfcb9314a239bea0f - Hive: Refactor commit lock mechanism from HiveTableOperations. This is mostly a refactoring to make it possible to do c3232b664745ebf761b6a74f4c5b55cc48bfd209 - fede493d59f17ff2bfc0744b296d90bd36130386 - Hive: Lock hardening (#6451) - makes sure that the Lock used by the Iceberg commit are cleared up... If you do not have stability issues with stuck Hive Locks then you might skip backporting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
