TuroczyX commented on PR #4272: URL: https://github.com/apache/hive/pull/4272#issuecomment-1525375405
I'm ok with this change and make sense. But the GenTezUtils is insanely big a complex. The cyclomatic complexity is too high to have a proper unit test for this class. Is there any intention to refactor this class, because this class is hurting closely all SOLID principals. Otherwise the change and the tests are OK to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
