zhangbutao commented on PR #4216: URL: https://github.com/apache/hive/pull/4216#issuecomment-1528833729
> Thanx @zhangbutao, overall changes looks good, dropped some comments. > > Additionally your code ain't formatted according to hive formatting rules, line length should be less than 120 and other, can refer here: https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml > > Additionally add a q test. Where you do an explain of the create branch statement before creating the branch. > > Add some failure test cases: Branch already exist and you try to create a branch Attempt to create a branch on a non iceberg table > > In the positive test case check for the data as well. I think i have addressed these comments. Please take a look again if you have time. Thanks @ayushtkn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
