scarlin-cloudera commented on PR #4212:
URL: https://github.com/apache/hive/pull/4212#issuecomment-1529778518
@zabetak : I'm not sure what is meant by a micro-benchmark. Can you
explain what is needed here or provide an example from a previous commit?
As for not being thread-safe: Not sure what you mean here. The "get" is
wrapped in a "synchronized" call. I don't think the underlying Calcite classes
will have any thread safety issues when I did the code inspection within
Calcite, but admittedly, I'm not a Calcite expert.
But without this code (as I hope to show with the micro-benchmarks
perhaps), we are regenerating Calcite classes which they specifically try to
avoid. It does add to the compile time as I have seen through my own private
benchmarks.
I do realize this is risky though. Do we have any framework within Hive
that does concurrency testing? If not, perhaps that is something I should
consider adding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
