dengzhhu653 commented on code in PR #4228:
URL: https://github.com/apache/hive/pull/4228#discussion_r1192242989
##########
iceberg/iceberg-handler/src/test/results/positive/col_stats.q.out:
##########
@@ -339,17 +339,16 @@ POSTHOOK: type: DESCTABLE
POSTHOOK: Input: default@tbl_ice_puffin
col_name a
data_type int
-min 1
-max 333
-num_nulls 0
-distinct_count 7
+min
+max
+num_nulls
+distinct_count
Review Comment:
This perhaps true for Iceberg table, as it will track its own metadata.
Think about a native external table, if there are some files under the table
directory on creation, then assumption probably is wrong(e,g min = 1, max=333)
after insertion.
If every time we create a new Iceberg table in HMS, the legacy files under
the table directory won't be read, e.g, the row number is 0 regardless of the
legacy files, then we can put
\"COLUMN_STATS\":{\"a\":\"true\",\"b\":\"true\",\"c\":\"true\" into table
parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
