schiller-oliver commented on code in PR #4329:
URL: https://github.com/apache/hive/pull/4329#discussion_r1195736197
##########
ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q:
##########
@@ -8,8 +8,8 @@ set hive.strict.checks.cartesian.product=false;
-- SORT_QUERY_RESULTS
-create database `db~!@#$%^&*(),<>`;
-use `db~!@#$%^&*(),<>`;
+create database `db"% &()*+,-/:;<=>?[]_|{}$^!~#``@`;
Review Comment:
I've to admit that I don't know what 'db_test' means.
However, I was thinking about adding a case to
`standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java`.
There is already a test that validates proper creation of the default location
based on the db name during db creation, but the db name is rather simple in
this case ("dummy"). I thought about adding another case that uses a db name
that contains few special characters and validates that the location contains
the encoded db name. Does this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
